Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data block number starting on 0 makes server incompatible with RFC 1350 #36

Closed
estevE11 opened this issue Oct 29, 2023 · 2 comments
Closed

Comments

@estevE11
Copy link

I had to implement a TFTP Client with RFC 1350 specifications for class and I think I found a bug where, when sending a file from client, the server expects first DATA block number to be 0 when it should be 1.

Here is what the documentation says: "The block numbers on data packets begin with one and increase by one for each new block of data."

Got into the code and printed the number the server receives and the one it expects. They are different so it stops the transfer.
image

Is this a bug or is it intentional and I'm missing something?

@estevE11
Copy link
Author

There's a fix already #31

@estevE11 estevE11 reopened this Oct 29, 2023
@mpetazzoni
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants