Faster Bios protocol #271
Merged
Faster Bios protocol #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would appreciate a fast turnaround to get this into Hackage as soon as possible. |
pepeiborra
force-pushed
the
generalize
branch
from
2e12482
to
1dd7003
Compare
|
This on its own does not constitute a major version bump, since the changes are backwards compatible and hardly any impact for most users. E.g. I don't even need to make a ghcide release to use these changes, simply a Cabal/stack constraint. Very happy to have it released today together with #264. Many thanks!! |
|
@jneira They did, but after using that commit for some time now and I could not find something that broke. At most, it doesn't fully avoid invalidating the cache? Or did you observe other problems as well? |
|
@fendor i am afraid i've not tested it, if it works for you it will be fine |
fendor
approved these changes
Dec 16, 2020
fendor
pushed a commit
to fendor/hie-bios
that referenced
this pull request
Dec 16, 2020
* generalize readProcessWithOutputFile to multiple outputs * Generalize readProcessWithOutputs to optional outputs * Bios cradle: retrieve OUTPUTS and DEPS in one call * Tests and docs * Fix Haddocks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the proposal in #270 to obtain the OUTPUTS and DEPS in a single run.
The implementation is careful to preserve backwards compatibility. If both the new and old mechanisms are used, the new mechanism takes precedence.