Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doesn't download full YouTube playlists #294

Closed
hotice opened this issue May 27, 2015 · 3 comments
Closed

Doesn't download full YouTube playlists #294

hotice opened this issue May 27, 2015 · 3 comments

Comments

@hotice
Copy link

hotice commented May 27, 2015

mps-youtube doesn't download complete YouTube playlists. The app can only download (e.g. using dapl <playlisturl>) the songs that fit on the terminal screen height - so for instance, when used with the standard Gnome Terminal window size, it only downloads 21-22 items from the playlist. If for instance I maximize the terminal window, then it can download more items (40-45 or so).

Tested using mps-youtube 0.2.4 under Ubuntu 15.04.
@ids1024 ids1024 added the bug label Jun 1, 2015
@JKatzwinkel
Copy link
Member

I have had this taken care of in another branch, can re-apply fix as soon as I find a little time.

JKatzwinkel added a commit to JKatzwinkel/mps-youtube that referenced this issue Jul 8, 2015
@JKatzwinkel
Make down_plist download entire playlist
464e2a3 
Change behaviour of `plist` when called with `dumps` flag so that playlist
downloads are no longer limited to the videos displayed in their first result
page. This should fix issue mps-youtube#294.
JKatzwinkel added a commit to JKatzwinkel/mps-youtube that referenced this issue Jul 8, 2015
@JKatzwinkel
Make down_plist download entire playlist
5c4f704 
Change behaviour of `plist` when called with `dumps` flag so that playlist
downloads are no longer limited to the videos displayed in their first result
page. This should fix issue mps-youtube#294.
@JKatzwinkel JKatzwinkel mentioned this issue Jul 8, 2015
Merged
@pnutus
Copy link

pnutus commented Aug 5, 2015

I'm not sure if this is the same bug, but if I say save when viewing a YouTube playlist, I expect the entire playlist to be downloaded. Instead, it only downloads the visible items. Looking in the help, this seems to be the intended behavior: save or save <name> - save the displayed items as a playlist. However, I can't find any way to just save a YouTube playlist locally (which to me seems more useful than the current behavior).

@ids1024
Copy link
Contributor

ids1024 commented Aug 5, 2015

@pnutus try running dump to get all the items, then save.

amacfie added a commit to amacfie/amacfie.github.io that referenced this issue Sep 14, 2015
@amacfie
Update Grooveshark post with playlist fix
4cc08b5 
mps-youtube/yewtube#294
BensonQiu pushed a commit to BensonQiu/mps-youtube that referenced this issue Dec 6, 2015
@JKatzwinkel @BensonQiu
Make down_plist download entire playlist
5038c3b 
Change behaviour of `plist` when called with `dumps` flag so that playlist
downloads are no longer limited to the videos displayed in their first result
page. This should fix issue mps-youtube#294.
@ids1024 ids1024 closed this as completed Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@pnutus @hotice @JKatzwinkel @ids1024