Download playlists #325
Merged
Download playlists #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change behaviour of `plist` when called with `dumps` flag so that playlist downloads are no longer limited to the videos displayed in their first result page. This should fix issue mps-youtube#294.
|
I am on vacation now away from my computer. I will merge this when I get back in a few days and have a chance to test this. |
|
Congrats! Take your time and enjoy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for issue #294.
plistwhen flagdumpsis set. Limitation of displayed items is moved togenerate_songlist.plistis called again withoutdumpsflag set, in order to re-enter browsing mode. This (27e1363) leads to some commands executed twice, but works well.