Additional information displayed #163
Conversation
| @@ -1788,7 +1788,7 @@ def generate_real_playerargs(song, override, failcount): | |||
| "Use mpv or download it" % song.title) | |||
|
|
|||
| size = get_size(song.ytid, stream['url']) | |||
| songdata = song.ytid, stream['ext'], int(size / (1024 ** 2)) | |||
| songdata = song.ytid, stream['ext'] + "@" + stream['quality'], int(size / (1024 ** 2)) | |||
There was a problem hiding this comment.
The extra characters may cause the line to wrap around sometimes. Is it possible to adjust the width of the progress bar dynamically (according to the width of the information on the left)?
There was a problem hiding this comment.
Problem is at line 1999, the size of the bar is not dynamically adjusted to the length of the information displayed before. I don't have access to the length of this text in the "make_status_line" function, however, so a quick fix would be to replace 50 by 54, which happens be sufficient. Does it seem ok?
There was a problem hiding this comment.
That seems like a reasonable hot fix without changing much of the existing structure! @np1 what do you think of it?
remove streams listing from video info screen
|
Thanks for the PR 👍 , I have made some changes to keep the status line length constant. I also removed the stream listing from the information screen because I prefer to keep the displayed information small enough to fit in a standard sized terminal window without needing to scroll where possible. Perhaps another key could be used to show the stream listing - it is available in the download screen anyway. |
Added display information on the play screen (the stream quality), as well as a list of available streams on the video information pages, as demanded in feature request #134