Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpu-next filter #11685

Closed
ghost opened this issue May 13, 2023 · 1 comment
Closed

gpu-next filter #11685

ghost opened this issue May 13, 2023 · 1 comment
Labels
meta:feature-request

Comments

@ghost
Copy link

ghost commented May 13, 2023 •
edited by ghost
Loading

No description provided.

@ghost ghost added the meta:feature-request label May 13, 2023
@dyphire
Copy link
Contributor

dyphire commented May 13, 2023 •
edited
Loading

You can already use vf=libplacebo or vf=tonemap to achieve color tone mapping thumbnails, ref po5/thumbfast@6c99377. But use video filters to achieve tone mapping is a bad idea, as it leads to very poor thumbnail generation performance.

The correct solution is to wait for #10678 implementation.

BtbN pushed a commit to FFmpeg/FFmpeg that referenced this issue May 13, 2023
@haasn
lavfi/vf_libplacebo: allow operation without avhwdevice
c65e481 
Recent versions of libplacebo have required Vulkan versions incompatible
with lavu Vulkan hwcontexts. While this is expected to change
eventually, breaking vf_libplacebo every time there is such a transition
period is obviously undesired behavior, as the following sea of bug
reports shows.

This commit adds a fallback path for init_vulkan failures which simply
creates an internal device if there was no user-supplied Vulkan hwaccel.
Useful when no interop with lavu vulkan hwframes is needed or desired,
and makes using this filter easier inside certain applications.

Fixes: haasn/libplacebo#170
Fixes: mpv-player/mpv#9589 (comment)
Fixes: mpv-player/mpv#11363
Fixes: mpv-player/mpv#11685 (comment)
Closes: https://code.videolan.org/videolan/libplacebo/-/issues/270
@ghost ghost closed this as completed May 13, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta:feature-request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dyphire