Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfault when printing vf-metadata name #1408

Closed
Argon- opened this issue Dec 30, 2014 · 4 comments
Closed

Segfault when printing vf-metadata name #1408

Argon- opened this issue Dec 30, 2014 · 4 comments

Comments

@Argon-
Copy link
Member

Argon- commented Dec 30, 2014

Two dummy entries for input.conf:

n vf add @mf:format=yuv420p
m show_text "${vf-metadata/mf}"

As long as n was not pressed, m displays the expected "(error)" string. However, once n was pressed (and the filter successfully added), m results in mpv segfaulting.

Thread 7 Crashed:: mpv/playback core (OSX)
0   ???                                 000000000000000000 0 + 0
1   mpv                                 0x0000000109e506b7 mp_property_vf_metadata + 103
2   mpv                                 0x0000000109e42e8c do_action + 316
3   mpv                                 0x0000000109e42814 m_property_do + 372
4   mpv                                 0x0000000109e433c9 m_properties_expand_string + 1177
5   mpv                                 0x0000000109e4bb72 run_command + 290
6   mpv                                 0x0000000109e6358b mp_process_input + 27
7   mpv                                 0x0000000109e652a2 run_playloop + 2322
8   mpv                                 0x0000000109e5b6d8 mp_play_files + 4776
9   mpv                                 0x0000000109e5cfdd mpv_main + 1053
10  mpv                                 0x0000000109ec61c9 playback_thread + 41
11  libsystem_pthread.dylib             0x00007fff8fd8e2fc _pthread_body + 131
12  libsystem_pthread.dylib             0x00007fff8fd8e279 _pthread_start + 176
13  libsystem_pthread.dylib             0x00007fff8fd8c4b1 thread_start + 13

Am I doing it wrong or is it a bug?

@ghost ghost closed this as completed in a5832ba Dec 30, 2014
@ghost
Copy link

ghost commented Dec 30, 2014

Was a bug; fixed it. There's no metadata with this filter, so it'll still display "error".

@Argon-
Copy link
Member Author

Argon- commented Dec 30, 2014

Thanks :)
I wanted to use this property as some kind of "is this filter already added" check. Is there some other way to do this?

ghost pushed a commit that referenced this issue Dec 30, 2014
If a filter exists, but has no metadata, just return success. This
allows the user to distinguish between no metadata available, and filter
not inserted.

See #1408.
@ghost
Copy link

ghost commented Dec 30, 2014

OK, made a small change, see commit above.

@Argon-
Copy link
Member Author

Argon- commented Dec 30, 2014

Works as expected, thanks!

ghost pushed a commit that referenced this issue Jan 24, 2015
This input command crashed:

    vf add @mf:format=yuv420p ; show_text "${vf-metadata/mf}"

Fixes #1408.
ghost pushed a commit that referenced this issue Jan 24, 2015
If a filter exists, but has no metadata, just return success. This
allows the user to distinguish between no metadata available, and filter
not inserted.

See #1408.
ghost pushed a commit that referenced this issue Jan 25, 2015
This input command crashed:

    vf add @mf:format=yuv420p ; show_text "${vf-metadata/mf}"

Fixes #1408.
ghost pushed a commit that referenced this issue Jan 25, 2015
If a filter exists, but has no metadata, just return success. This
allows the user to distinguish between no metadata available, and filter
not inserted.

See #1408.
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant