Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--sub-scale applied when --sub-ass-override is set to yes #14229

Closed
6 tasks done
low-batt opened this issue May 25, 2024 · 0 comments · Fixed by #14234
Closed
6 tasks done

--sub-scale applied when --sub-ass-override is set to yes #14229

low-batt opened this issue May 25, 2024 · 0 comments · Fixed by #14234
Labels

Comments

@low-batt
Copy link
Contributor

mpv Information

mpv v0.38.0-344-g2fa66b850d Copyright © 2000-2024 mpv/MPlayer/mplayer2 projects
 built on May 24 2024 21:30:52
libplacebo version: v7.349.0 (v6.338.0-133-g9e1257c8)
FFmpeg version: n7.0
FFmpeg library versions:
   libavutil       59.8.100
   libavcodec      61.3.100
   libavformat     61.1.100
   libswscale      8.1.100
   libavfilter     10.1.100
   libswresample   5.1.100

Other Information

  • macOS version: macOS 13.6.3 (22G436)
  • Source of mpv: local build of master at 2fa66b8 using mpv-build
  • Introduced in version: unknown

Reproduction Steps

  • Download the attached big_buck_bunny.ass.txt file
  • Rename it to big_buck_bunny.ass
  • Copy some video to big_buck_bunny.mp4 in the same directory to match up with subtitle file
  • Play the video with --sub-scale=5 --sub-ass-override=no
  • Play the video with --sub-scale=5 --sub-ass-override=yes
  • Notice --sub-scale is applied with --sub-ass-override set to yes

Expected Behavior

I'm expecting:

  • With --sub-ass-override=no, --sub-scale is ignored
  • With --sub-ass-override=yes, --sub-scale is ignored
  • With --sub-ass-override=scale, --sub-scale overrides ASS style

From the mpv manual entry for the sub-ass-override option:

  • no: Render subtitles as specified by the subtitle scripts, without overrides.
  • yes: Apply all the --sub-ass-* style override options. Changing the default for any of these options can lead to incorrect subtitle rendering (default).
  • scale: Like yes, but also apply --sub-scale.

Actual Behavior

With --sub-ass-override=yes, --sub-scale is applied and overrides ASS style. The --sub-ass-override=yes behavior matches the --sub-ass-override=scale behavior.

With --sub-ass-override=no:

mpv/build/mpv --log-file=mpv.log --no-config --autofit=2048 --pause --sub-scale=5 --sub-ass-override=no ~/Movies/big_buck_bunny.mp4

no

With --sub-ass-override=yes:

mpv/build/mpv --log-file=mpv.log --no-config --autofit=2048 --pause --start=1:08 --sub-scale=5 --sub-ass-override=yes ~/Movies/big_buck_bunny.mp4

yes

With --sub-ass-override=scale it looks just like --sub-ass-override=yes.

Am I confused about how sub-ass-override is intended to work?

Log File

output.txt

Sample Files

big_buck_bunny.ass.txt

I carefully read all instruction and confirm that I did the following:

  • I tested with the latest mpv version to validate that the issue is not already fixed.
  • I provided all required information including system and mpv version.
  • I produced the log file with the exact same set of files, parameters, and conditions used in "Reproduction Steps", with the addition of --log-file=output.txt.
  • I produced the log file while the behaviors described in "Actual Behavior" were actively observed.
  • I attached the full, untruncated log file.
  • I attached the backtrace in the case of a crash.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant