gpu-next: add support for --dither-depth=auto #13646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 6, 2024
|
Download the artifacts for this pull request: |
na-na-hi
reviewed
Mar 6, 2024
|
This doesn't actually fix the linked issue, since the color_depth function is not implemented on Vulkan, and on OpenGL it doesn't actually get real bpc although banding is only observed on Vulkan and d3d11. Definitely an improvement over what I was trying though. |
|
It does fix the issue for d3d11, limitations of other APIs are here and would need other way to query to dither target value. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.