Use system LC_CTYPE for libarchive #6438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 13, 2019
Closed
|
as a new contributor it would be nice if you read contribute.md. specifically the commit messages and body in this case, eg adding the prefix of the subsystem (stream_libarchive:) before the message, possibly adding a small explanation of the issue into the commit body and referencing the original issue with "Fixes #5759" (this will auto close that issue in case of a merge). |
Fixes mpv-player#5759 LC_ALL is unreliable on some systems. Setting C.UTF-8 doesn't work on systems without a C.UTF-8 locale.
|
Updated, that good now? |
|
yeah commit message seems good to me now. |
|
LGTM |
|
Can confirm that this fixes #6488 failures on NixOS. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should improve locale support for systems that don't have a
C.UTF-8locale.From my testing only
LC_CTYPE_MASKwas needed andLC_ALL_MASKappeared to be broken on some systems(note I tested this as part of a different application but it appears to be used in the same way here).