libarchive: add fallback for systems without C.UTF-8 #6683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dudemanguy
force-pushed
the
locale-fallback
branch
from
1fd7272
to
672ff78
Compare
Dudemanguy
force-pushed
the
locale-fallback
branch
from
672ff78
to
917d3e8
Compare
sfan5
approved these changes
May 3, 2019
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in IRC as a possible fix to #5759 and #6488. Currently libarchive uses C.UTF-8 as a locale, but that is debian specific and thus broken on other linux distros and macOS. This PR leaves C.UTF-8 as the default, but falls back to LC_CTYPE which should just use the environment variable of the current system. Of course, this also supersedes #6438 and #6268.
I agree that my changes can be relicensed to LGPL 2.1 or later.