-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "path: switch back to using non-XDG config dir by default" #7978
Conversation
This reverts commit 269f0e7.
In fact, the commit you want to revert switches back to the simpler convention, that has been the default in mpv for longer than the XDG one. Also, while compatible, it does prevent creating the impression that mpv supports XDG properly. It does not. Things like support for Thus a clear "reject" from me. Not sure why you have to dig this whole issue out again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nope
|
I don't care about supporting every little xdg thing (some are good; some are bad), but I agree that |
I think it would be nice to fully support the XDG directory spec where applicable as documented on this one short page, but at least https://specifications.freedesktop.org/basedir-spec/basedir-spec-latest.html |
While I think that the full XDG directory spec would not be necessary, XDG_CONFIG_HOME is a well established spec and you guys should expect that distro packagers won't like this and will likely be patched downstream. |
@orbea out of all of those, I don't think much beyond |
And I was seeing some scripts that still have in their documentation to copy the .lua to ~/.config/mpv and many other things. This change to not use |
These were never correct. Systems which used a different XDG_CONFIG_HOME, and installations which used the "compatibility" config location (now the default) didn't use that path. In fact, after a few years it will be less confusing because XDG_CONFIG_HOME no longer matters. |
But systems with the configs in ~/.config/mpv probably are the majority now, they where correct when they were written. All major applications are already on XDG_CONFIG_HOME(with some exceptions like Firefox, vim and Wine) -- neovim is already more popular than mainline vim, like mpv is more popular than mplayer, and uses XDG_CONFIG_HOME. Even proprietary apps like Steam stopped using ~/.Steam. I don't like GNOME and many things they push in the Freedestop's specs, but abandoning XDG_CONFIG_HOME is a step back. |
@wm4 As @emanuele6 pointed out, only few apps are continuing to be eye-sores. Which is why it's universally baffling that you're so adamant about joining their ranks. |
I think you mentioned the wrong person, @v-fox. ping @emanuelserpa |
I'm pretty sure it's time for |
No it's not time for a fork. Please do not comment on this PR if you don't have anything constructive to say on the argument of the merits of restoring If you want to shitpost go to 269f0e7's comment section. |
~/.config is still a dumping ground for myriad of not-so-hidden-and-often-needed-to-be-accessed directories and files. You achieved nothing. ~/.cache (and also ~/.local) is a good convention, and is often pointed out as decisive advantage of XDG. But you can have that without all the other XDG rules, especially without .config. Also, you can still make mpv to use .config, where's the problem? People who prefer the old convention have it harder. |
@wm4 You're blatantly wrong in a few obvious ways.
|
No, it's not disruptive in any sense of the word.
Maybe that's true, but not if you consider ~/.config/* and ~/.?*
No idea what you're even talking about. |
It clearly is, look at the response you are getting. You're acting like the xscreensaver dev when he told me that he refuses to support the XSS because its "bad". (I didn't get a specific reason)
I have 198 hidden files or directories in ~, its an utter mess. On the other hand ~/.config has only 90 files or directories where none of them are hidden and are for the most part actually configs, its far less of a mess.
What part of ignoring standards being bad is hard to understand? |
Still wondering what you think you have gained with XDG.
It's not a standard, just some stuff some people made up. |
You don't have to use XDG to put your And even if it didn't look in If you really want to use You don't need Also, What's the problem? I don't get what you think it's the problem: you seem to act as if You don't need to have If you want to debate that |
The problem is new users knowing nothing about this, getting a
All of these statements are completely missing the point. Let me put the main points in a list:
Any debate on the technical feasibility of "XDG support" is out of scope. |
I wouldn't say that EDIT: |
You're right it's not supported unless it is by default, and this PR reverts 269f0e7 which removed it as the default. This PR restores it as the default and restores the previous behavior mpv had as well as the default for all downstream linux users. If you look at the code mpv properly checks Lines 33 to 41 in b5d5678
|
Going by the numbers of @orbea (and I've counted my own files too), the "old" convention (which .config ironically follows by using the Edit: and of course, the "old" convention is still a living standard. |
The fact that |
Only if by "myriad" you mean Firefox, Wine, Gimp and, now, mpv.
Or you can have all of those for everything if outliers stop their stubborn clinging to things that no one wants or benefits from.
And I can kludge-up something similar for Firefox and Wine. But I prefer to not do anything and just have application not do stupid counter-productive stuff that I have to fix right after installation.
The problem is doing work of an application for it. Now you just shifted the problem into workaround shell-scripts.
I still don't get that: a screensaver service & pack that can't actually trigger properly on idle because it does not track idle-time. That's the reason I had to remove xscreensaver from all my machines and forget about it. There is still problem with emulators not stopping X's blanking/poweroff for some reason but at least mpv is not being interrupted by screensaver anymore.
Well, luckily, I only have some outliers, old remains and backups, something I could clean-up further.
Just like RFCs and IEEE 802.*. Stuff that works great when everyone follow it. |
I'm not really sure if everyone understood this, but: if |
It's not a workaround:
You can't call this a workaround: If you don't set XDG_CONFIG_HOME, you can still use If you want to use a directory different from these two (e.g. one in XDG_CONFIG_HOME), you should set MPV_HOME. |
I understand this just fine, this discussion is about what the default should be. I am arguing that
This has, again, never been part of the argument. Of course you can still use |
Honestly it doesn't even need to be I would suggest checking config directories in this order.
Pick the fist one that is found in this list, that should make just about everyone happy. This issue is making a mountain out of a molehill. |
Number 4 on that list is unnecessary and should be removed (definitely pointless complication at that point) but otherwise I like the suggestion. |
Definitely not 4, that's not what this PR is about. Currently the way config parsing is done, by your list, is 1, 3, 2, 5. I'm really just advocating that it be switched back to 1, 2, 3, 5. |
I agree that |
Gimp migrated to XDG in 2015. :-) You probably just have to remove/move the folder. |
@soc Yep. As I've said, I haven't bothered to clean all of old poop yet. And this doesn't make it easier. Firefox and Wine are still like that with their profiles/prefixes and developers that think they are too good for a sub-directory. I'm surprised that KDE got in line with it though, even if it seems like that was the only good thing since KDE3. |
@v-fox I'm down to a dozen folders, and because my $HOME is read-only new, misbehaving applications can't add new ones. |
I'm thinking about doing the same @soc. (read-only $HOME) |
@emanuelserpa Cool! Here is an article I wrote on Defending $HOME, maybe it's useful to you. |
I don't understand this obsession with moving the mess from ~/ to ~/.config, all while policing random projects that didn't give in yet and deriding them if they don't agree to adopt XDG. Making HOME itself read-only is the ultimate tip of the iceberg, because obviously that leaves you enable to do anything with HOME. I've had enough, bugger off. |
This reverts commit 269f0e7.
This commit was a rash decision that does not bring any benefits to mpv. It did not reduce code complexity and it did not improve compatibility with other POSIX and/or UNIX-like OSes. On the contrary, the only thing this commit did was break a convention that existed for years in mpv. It is a step backwards for users who do not like dotfiles cluttering their
$HOME
and for attempts by distros and other downstream users to standardize their configuration files. The XDG specification may not be perfect but it is a standard used on linux and some other OSes.Reverting this commit before the 0.33 release will mean that distros will not ship any release with this commit in it and
$XDG_CONFIG_HOME
will still be the default for new mpv users downstream.