Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mac: support --on-all-workspaces option #8586

Merged
merged 3 commits into from
Feb 21, 2021
Merged

mac: support --on-all-workspaces option #8586

merged 3 commits into from
Feb 21, 2021

Conversation

gch1p
Copy link
Contributor

@gch1p gch1p commented Feb 20, 2021

No description provided.

@Akemi
Copy link
Member

Akemi commented Feb 20, 2021

you probably want to make it runtime changeable too here https://github.com/mpv-player/mpv/blob/master/video/out/mac/common.swift#L533-L565

@gch1p
Copy link
Contributor Author

gch1p commented Feb 20, 2021

you probably want to make it runtime changeable too here https://github.com/mpv-player/mpv/blob/master/video/out/mac/common.swift#L533-L565

done

@Akemi
Copy link
Member

Akemi commented Feb 20, 2021

please separate the changes to the menubar and command.c from the rest into their own two commits. they are independent changes and should be treated as such.

@gch1p
Copy link
Contributor Author

gch1p commented Feb 20, 2021

please separate the changes to the menubar and command.c from the rest into their own two commits. they are independent changes and should be treated as such.

how about this?

@Akemi
Copy link
Member

Akemi commented Feb 20, 2021 •
edited
Loading

command: support on-all-workspaces command this commit message is misleading, it just changes the string that os shown on the OSD.

@gch1p
Copy link
Contributor Author

gch1p commented Feb 20, 2021 •
edited
Loading

how about osd: add label for the on-all-workspaces command?

@Akemi
Copy link
Member

Akemi commented Feb 20, 2021

i think the command prefix is fine command: add label for on-all-workspaces command.

@gch1p
Copy link
Contributor Author

gch1p commented Feb 20, 2021

done

@Akemi
Copy link
Member

Akemi commented Feb 21, 2021

thank you for your work.

@Akemi Akemi merged commit 56669fb into mpv-player:master Feb 21, 2021
@gch1p gch1p deleted the macos-on-all-workspaces branch February 21, 2021 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gch1p @Akemi