Skip to content
This repository has been archived by the owner on Oct 11, 2021. It is now read-only.

Couldn't load the draggabilly bower package #61

Closed
avital opened this issue Feb 17, 2015 · 6 comments
Closed

Couldn't load the draggabilly bower package #61

avital opened this issue Feb 17, 2015 · 6 comments
Labels
bug

Comments

@avital
Copy link

avital commented Feb 17, 2015

Repro app here: https://github.com/avital/try-bower-draggabilly

Trying to use the draggabilly bower library. Run the app and you'll see a exception on the client at pageload. Looks like it can't find the getStyleProperty global that was supposed to be added by the desandro-get-style-property bower package? But it does looks like it loaded that package -- maybe it's a dependency load order issue?
@gbisheimer
Copy link
Contributor

Try with this bower.json with latest meteor-bower release (that supports overrides)

{
  "name": "my-app",
  "version": "0.0.1",
  "dependencies": {
    "draggabilly": "~1.1.2"
  },
  "private": true,
  "overrides":
  {
    "draggabilly":
    {
        "main": ["../eventEmitter/EventEmitter.js","../get-style-property/get-style-property.js", "draggabilly.js"]
    }
  }
}

This will load required dependencies first.

@lorensr shouldn't be all declared files in main section of all nested dependencies be included by default?

@lorensr
Copy link
Collaborator

lorensr commented Feb 17, 2015

Hey there father's dew! I'll fix your bug if you fix mine? j/k :D. @gbisheimer it should be. I tried your overrides, still doesn't include get-style-property.js at all, let alone first. Debugging now

@lorensr
Copy link
Collaborator

lorensr commented Feb 17, 2015

A bad current fix would be adding the deps to beginning of your bower.json:

  "dependencies": {
      "get-style-property": "1.0.4",
      ...
      "draggabilly": "~1.1.2"
  },

still debugging...

@gbisheimer gbisheimer mentioned this issue Feb 17, 2015
Closed
@lorensr lorensr added the bug label Feb 17, 2015
@gbisheimer
Copy link
Contributor

@lorensr, posted bower.json worked for me, all files where injected into <HEAD> section. Forgot to mention i'm using the last version of this package from my repository. Don't know if this may be the issue.

@gbisheimer
Copy link
Contributor

Will be fixed once PR #63 is merged.

@lorensr
Copy link
Collaborator

lorensr commented Feb 18, 2015

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@avital @lorensr @gbisheimer