Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement] Advertise Python2 as the only supported python version for the fwknop python extension #167

Open
Coacher opened this issue Jul 29, 2015 · 5 comments
Assignees
Milestone

Comments

@Coacher
Copy link
Contributor

Coacher commented Jul 29, 2015

Hello.

Currently the fwknop python extension does not specify supported python versions in setup.py or README. This makes using this extension troublesome, since user has to go through the trial-and-error process to determine the required python version. For example, on my machine I am able to use this extension with python 2.7, but not with python 3.3, and I have no clue if this the intended behaviour or not.

Please add the supported Python versions to setup.py. One of the standard ways to do this is through 'classifiers'. See https://docs.python.org/2/distutils/setupscript.html#additional-meta-data Full list: https://pypi.python.org/pypi?%3Aaction=list_classifiers

@mrash
Copy link
Owner

mrash commented Jul 31, 2015

Agreed, fwknop should publish details on Python version dependencies. Thanks for the suggestion.

@Coacher
Copy link
Contributor Author

Coacher commented Sep 5, 2015

I've investigated a bit further. On Python 3.4 I have the following error after fko module import attempt:

ImportError: <long_path_here>/_fko.cpython-34.so: undefined symbol: Py_InitModule

This error is due to changes in Python 3 module initialization.
See https://docs.python.org/3/howto/cporting.html#module-initialization-and-state
And http://python3porting.com/cextensions.html#module-initialization

Therefore fko python module does not have proper Python 3 support atm. Please adjust classifiers accordingly.

@Coacher Coacher changed the title [Enhancement] Advertise supported python versions for the fwknop python extension [Enhancement] Advertise Python2 as the only supported python version for the fwknop python extension Sep 5, 2015
@mrash mrash added this to the fwknop-2.7.0 milestone Sep 19, 2015
@mrash mrash self-assigned this Sep 19, 2015
@anthraxx
Copy link

anthraxx commented Dec 8, 2015

just an idea, but how about fixing python3 support instead of documenting that its only functional for python2? 😜

@hlein
Copy link
Contributor

hlein commented Jan 29, 2020

Python3 support would be helpful since Python2 is deprecated, and distributions are starting to remove it.

I'm a terribad python programmer, or I would volunteer to help.

@exx8
Copy link

exx8 commented Feb 4, 2020

As python 2 has been decrepated, I suggest moving py script altogether to py 3, I might be able to offer some help within half a year from now. Will a PR porting to python 3 will be accepted?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants