We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently the threadID is leaking into all datastructures.
It seems like "obvious facilities" do not fit:
pthread_self
gettid
syscall(__NR_gettid)
pthread_getthreadid_np
getThreadID
This is necessary to decouple the memory management and allow upstreaming it.
LookAside list:
weave/weave/memory/lookaside_lists.nim
Lines 49 to 60 in ed177ff
Mempool free requires the caller to supply its ThreadID
free
weave/weave/memory/memory_pools.nim
Lines 484 to 519 in bbc677b
References https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreadid https://stackoverflow.com/questions/21091000/how-to-get-thread-id-of-a-pthread-in-linux-c-program
The text was updated successfully, but these errors were encountered:
Successfully merging a pull request may close this issue.
Currently the threadID is leaking into all datastructures.
It seems like "obvious facilities" do not fit:
pthread_self
return a pthread handlegettid
is Linux onlysyscall(__NR_gettid)
is Linux only (and involves a syscall)pthread_getthreadid_np
is BSD onlygetThreadID
is Windows-onlyThis is necessary to decouple the memory management and allow upstreaming it.
LookAside list:
weave/weave/memory/lookaside_lists.nim
Lines 49 to 60 in ed177ff
Mempool
free
requires the caller to supply its ThreadIDweave/weave/memory/memory_pools.nim
Lines 484 to 519 in bbc677b
References
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreadid
https://stackoverflow.com/questions/21091000/how-to-get-thread-id-of-a-pthread-in-linux-c-program
The text was updated successfully, but these errors were encountered: