Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use "time" not "step" in dust 0.12.x #222

Merged
merged 14 commits into from
Nov 10, 2022
Merged

Update to use "time" not "step" in dust 0.12.x #222

merged 14 commits into from
Nov 10, 2022

Conversation

richfitz
Copy link
Member

@richfitz richfitz commented Nov 4, 2022

Fairly robotic, but also fairly painful. Once this is passing there are a couple of rough edges that can be smoothed over as this package was already having a bit of a fight with both step and time being used

@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (a1134f0) compared to base (802ae3c).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #222   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         2851      2834   -17     
=========================================
- Hits          2851      2834   -17     
Impacted Files Coverage Δ
R/deterministic.R 100.00% <100.00%> (ø)
R/deterministic_state.R 100.00% <100.00%> (ø)
R/if2.R 100.00% <100.00%> (ø)
R/particle_filter.R 100.00% <100.00%> (ø)
R/particle_filter_data.R 100.00% <100.00%> (ø)
R/particle_filter_multistage.R 100.00% <100.00%> (ø)
R/particle_filter_state.R 100.00% <100.00%> (ø)
R/pmcmc_state.R 100.00% <100.00%> (ø)
R/predict.R 100.00% <100.00%> (ø)
R/trajectories.R 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@richfitz richfitz marked this pull request as ready for review November 7, 2022 10:58
@richfitz
Copy link
Member Author

richfitz commented Nov 7, 2022

This was read for review, until the that last version bump, which looks to have done something terrible to the version of dust installed; looks like remotes decided it would "upgrade" dust to a previous version on the logs. I'll open a separate PR that updates this to new actions, but in the meantime I think this is still ok to look at

@richfitz richfitz merged commit d73f0ff into master Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants