Skip to content

Commit

Permalink
Merge pull request #13795 from Mugen87/dev1
Browse files Browse the repository at this point in the history 
ExtrudeGeometry: Refactor interface.
  • Loading branch information
@mrdoob
mrdoob committed Apr 8, 2018
2 parents 0317e8e + 0e82588 commit 04e7595
Show file tree
Hide file tree
Showing 4 changed files with 377 additions and 466 deletions.
43 changes: 0 additions & 43 deletions docs/api/geometries/ExtrudeBufferGeometry.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,49 +92,6 @@ <h3>[name]([param:Array shapes], [param:Object options])</h3>
applied to the face; the second material will be applied to the sides.
</p>


<h2>Properties</h2>


<h2>Methods</h2>

<h3>[method:null addShapeList]([param:Array shapes], [param:Object options])</h3>
<p>
shapes — An Array of shapes to add. <br />
options — Object that can contain the following parameters.
<ul>
<li>curveSegments — int. Number of points on the curves. Default is 12.</li>
<li>steps — int. Number of points used for subdividing segments along the depth of the extruded spline. Default is 1.</li>
<li>amount — int. Depth to extrude the shape. Default is 100.</li>
<li>bevelEnabled — bool. Apply beveling to the shape. Default is true.</li>
<li>bevelThickness — float. How deep into the original shape the bevel goes. Default is 6.</li>
<li>bevelSize — float. Distance from the shape outline that the bevel extends. Default is bevelThickness - 2.</li>
<li>bevelSegments — int. Number of bevel layers. Default is 3.</li>
<li>extrudePath — THREE.CurvePath. A 3D spline path along which the shape should be extruded.</li>
<li>UVGenerator — Object. object that provides UV generator functions</li>
</ul>
</p>
<p>Adds the shapes to the list to extrude.</p>

<h3>[method:null addShape]([param:Shape shape], [param:Object options])</h3>
<p>
shape — A shape to add. <br />
options — Object that can contain the following parameters.
<ul>
<li>curveSegments — int. Number of points on the curves. Default is 12.</li>
<li>steps — int. Number of points used for subdividing segments along the depth of the extruded spline. Default is 1.</li>
<li>amount — int. Depth to extrude the shape. Default is 100.</li>
<li>bevelEnabled — bool. Apply beveling to the shape. Default is true.</li>
<li>bevelThickness — float. How deep into the original shape the bevel goes. Default is 6.</li>
<li>bevelSize — float. Distance from the shape outline that the bevel extends. Default is bevelThickness - 2.</li>
<li>bevelSegments — int. Number of bevel layers. Default is 3.</li>
<li>extrudePath — THREE.CurvePath. A 3D spline path along which the shape should be extruded.</li>
<li>UVGenerator — Object. object that provides UV generator functions</li>
</ul>
</p>
<p>Add the shape to the list to extrude.</p>


<h2>Source</h2>

[link:https://github.com/mrdoob/three.js/blob/master/src/geometries/ExtrudeGeometry.js src/geometries/ExtrudeGeometry.js]
Expand Down
43 changes: 0 additions & 43 deletions docs/api/geometries/ExtrudeGeometry.html
View file
Original file line number Diff line number Diff line change
Expand Up @@ -92,49 +92,6 @@ <h3>[name]([param:Array shapes], [param:Object options])</h3>
applied to the face; the second material will be applied to the sides.
</p>


<h2>Properties</h2>


<h2>Methods</h2>

<h3>[method:null addShapeList]([param:Array shapes], [param:Object options])</h3>
<p>
shapes — An Array of shapes to add. <br />
options — Object that can contain the following parameters.
<ul>
<li>curveSegments — int. Number of points on the curves. Default is 12.</li>
<li>steps — int. Number of points used for subdividing segments along the depth of the extruded spline. Default is 1.</li>
<li>amount — int. Depth to extrude the shape. Default is 100.</li>
<li>bevelEnabled — bool. Apply beveling to the shape. Default is true.</li>
<li>bevelThickness — float. How deep into the original shape the bevel goes. Default is 6.</li>
<li>bevelSize — float. Distance from the shape outline that the bevel extends. Default is bevelThickness - 2.</li>
<li>bevelSegments — int. Number of bevel layers. Default is 3.</li>
<li>extrudePath — THREE.CurvePath. A 3D spline path along which the shape should be extruded.</li>
<li>UVGenerator — Object. object that provides UV generator functions</li>
</ul>
</p>
<p>Adds the shapes to the list to extrude.</p>

<h3>[method:null addShape]([param:Shape shape], [param:Object options])</h3>
<p>
shape — A shape to add. <br />
options — Object that can contain the following parameters.
<ul>
<li>curveSegments — int. Number of points on the curves. Default is 12.</li>
<li>steps — int. Number of points used for subdividing segments along the depth of the extruded spline. Default is 1.</li>
<li>amount — int. Depth to extrude the shape. Default is 100.</li>
<li>bevelEnabled — bool. Apply beveling to the shape. Default is true.</li>
<li>bevelThickness — float. How deep into the original shape the bevel goes. Default is 6.</li>
<li>bevelSize — float. Distance from the shape outline that the bevel extends. Default is bevelThickness - 2.</li>
<li>bevelSegments — int. Number of bevel layers. Default is 3.</li>
<li>extrudePath — THREE.CurvePath. A 3D spline path along which the shape should be extruded.</li>
<li>UVGenerator — Object. object that provides UV generator functions</li>
</ul>
</p>
<p>Add the shape to the list to extrude.</p>


<h2>Source</h2>

[link:https://github.com/mrdoob/three.js/blob/master/src/[path].js src/[path].js]
Expand Down
25 changes: 25 additions & 0 deletions src/Three.Legacy.js
View file
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@ import { SkeletonHelper } from './helpers/SkeletonHelper.js';
import { BoxGeometry } from './geometries/BoxGeometry.js';
import { EdgesGeometry } from './geometries/EdgesGeometry.js';
import { ExtrudeGeometry } from './geometries/ExtrudeGeometry.js';
import { ExtrudeBufferGeometry } from './geometries/ExtrudeGeometry.js';
import { ShapeGeometry } from './geometries/ShapeGeometry.js';
import { WireframeGeometry } from './geometries/WireframeGeometry.js';
import { Light } from './lights/Light.js';
Expand Down Expand Up @@ -1202,6 +1203,30 @@ Object.defineProperties( BufferGeometry.prototype, {

//

Object.assign( ExtrudeBufferGeometry.prototype, {

getArrays: function () {

console.error( 'THREE.ExtrudeBufferGeometry: .getArrays() has been removed.' );

},

addShapeList: function () {

console.error( 'THREE.ExtrudeBufferGeometry: .addShapeList() has been removed.' );

},

addShape: function () {

console.error( 'THREE.ExtrudeBufferGeometry: .addShape() has been removed.' );

}

} );

//

Object.defineProperties( Uniform.prototype, {

dynamic: {
Expand Down
Loading

0 comments on commit 04e7595

Please sign in to comment.