GLTFExporter: Add early exit if attributes not found in processMesh

mrdoob · Mar 25, 2018 · bbf74b9 · bbf74b9
1 parent 214435b
commit bbf74b9
Showing 1 changed file with 12 additions and 10 deletions.
diff --git a/examples/js/exporters/GLTFExporter.js b/examples/js/exporters/GLTFExporter.js
@@ -975,6 +975,13 @@ THREE.GLTFExporter.prototype = {
 
 			}
 
+			// Skip if no exportable attributes found
+			if ( Object.keys( attributes ).length === 0 ) {
+
+				return null;
+
+			}
+
 			// Morph targets
 			if ( mesh.morphTargetInfluences !== undefined && mesh.morphTargetInfluences.length > 0 ) {
 
@@ -1107,21 +1114,16 @@ THREE.GLTFExporter.prototype = {
 
 				}
 
-				// Skip meshes without exportable attributes
-				if ( Object.keys( primitive.attributes ).length > 0 ) {
+				var material = processMaterial( materials[ groups[ i ].materialIndex ] );
 
-					var material = processMaterial( materials[ groups[ i ].materialIndex ] );
+				if ( material !== null ) {
 
-					if ( material !== null ) {
-
-						primitive.material = material;
-
-					}
-
-					primitives.push( primitive );
+					primitive.material = material;
 
 				}
 
+				primitives.push( primitive );
+
 			}
 
 			if ( didForceIndices ) {