Skip to content

Commit

Permalink
Reverting to Object.prototype = { pattern. Only using it on the metho…
Browse files Browse the repository at this point in the history
…ds that really need it.

Misteriously when using the latest version of the lib on the project I'm working on I'm getting this error:
> Uncaught TypeError: Object [object Object] has no method 'set'
This is caused when THREE.UniformsLib.common.diffuse initialises a THREE.Color (THREE.Color.set() seems to be undefined then).
For some reason this only happens when I load Box2D before three.js. If I load it after is all good. But this fixes the problem too.
/ping @bhouston
  • Loading branch information
mrdoob committed Mar 14, 2013
1 parent 1ce2b5b commit cc57273
Show file tree
Hide file tree
Showing 19 changed files with 542 additions and 468 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ This code creates a scene, then creates a camera, adds the camera and cube to th
### Change log ###


2013 03 15 - **r57** (403,596 KB, gzip: 96,362 KB)
2013 03 15 - **r57** (403,818 KB, gzip: 96,416 KB)

* Added Renderer panel to the editor. ([mrdoob](http://github.com/mrdoob))
* Added support for custom attributes to `BufferGeometry`. ([zz85](http://github.com/zz85))
Expand Down

2 comments on commit cc57273

@bhouston
Copy link
Contributor

@bhouston bhouston commented on cc57273 Mar 15, 2013 via email

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrdoob
Copy link
Owner Author

@mrdoob mrdoob commented on cc57273 Mar 15, 2013

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am okay with this. It shouldn't have been necessary though. Which box2d library did you use?

This one: https://code.google.com/p/box2dweb/downloads/detail?name=Box2dWeb-2.1a.3.zip

Please sign in to comment.