Skip to content

Commit

Permalink
WebGPURenderer: Fix Renderer dispose() (#27471)
Browse files Browse the repository at this point in the history
* fix dispose

* temporary remove _properties
  • Loading branch information
RenaudRohlinger committed Dec 30, 2023
1 parent 4326c9f commit eda87b2
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion examples/jsm/renderers/common/DataMap.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ class DataMap {

dispose() {

this.data.clear();
this.data = new WeakMap();

}

Expand Down
2 changes: 0 additions & 2 deletions examples/jsm/renderers/common/Renderer.js
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,6 @@ class Renderer {
this._scissor = new Vector4( 0, 0, this._width, this._height );
this._scissorTest = false;

this._properties = null;
this._attributes = null;
this._geometries = null;
this._nodes = null;
Expand Down Expand Up @@ -660,7 +659,6 @@ class Renderer {

this._animation.dispose();
this._objects.dispose();
this._properties.dispose();
this._pipelines.dispose();
this._nodes.dispose();
this._bindings.dispose();
Expand Down

0 comments on commit eda87b2

Please sign in to comment.