TransformControls: Set touchAction instead of touchstart listener.

mrdoob · Sep 1, 2020 · fef0b7a · fef0b7a
1 parent 52fb198
commit fef0b7a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/examples/js/controls/TransformControls.js b/examples/js/controls/TransformControls.js
@@ -125,7 +125,7 @@ THREE.TransformControls = function ( camera, domElement ) {
 
 	{
 
-		domElement.addEventListener( "touchstart", onTouchStart, false );
+		domElement.style.touchAction = 'none'; // disable touch scroll
 		domElement.addEventListener( "pointerdown", onPointerDown, false );
 		domElement.addEventListener( "pointermove", onPointerHover, false );
 		scope.domElement.ownerDocument.addEventListener( "pointerup", onPointerUp, false );
@@ -134,7 +134,7 @@ THREE.TransformControls = function ( camera, domElement ) {
 
 	this.dispose = function () {
 
-		domElement.removeEventListener( "touchstart", onTouchStart );
+		domElement.style.touchAction = '';
 		domElement.removeEventListener( "pointerdown", onPointerDown );
 		domElement.removeEventListener( "pointermove", onPointerHover );
 		scope.domElement.ownerDocument.removeEventListener( "pointermove", onPointerMove );
@@ -654,14 +654,6 @@ THREE.TransformControls = function ( camera, domElement ) {
 
 	}
 
-	function onTouchStart( event ) {
-
-		if ( scope.enabled === false ) return;
-
-		event.preventDefault(); // prevent scrolling
-
-	}
-
 	// TODO: deprecate
 
 	this.getMode = function () {

diff --git a/examples/jsm/controls/TransformControls.js b/examples/jsm/controls/TransformControls.js
@@ -146,7 +146,7 @@ var TransformControls = function ( camera, domElement ) {
 
 	{
 
-		domElement.addEventListener( "touchstart", onTouchStart, false );
+		domElement.style.touchAction = 'none'; // disable touch scroll
 		domElement.addEventListener( "pointerdown", onPointerDown, false );
 		domElement.addEventListener( "pointermove", onPointerHover, false );
 		scope.domElement.ownerDocument.addEventListener( "pointerup", onPointerUp, false );
@@ -155,7 +155,7 @@ var TransformControls = function ( camera, domElement ) {
 
 	this.dispose = function () {
 
-		domElement.removeEventListener( "touchstart", onTouchStart );
+		domElement.style.touchAction = '';
 		domElement.removeEventListener( "pointerdown", onPointerDown );
 		domElement.removeEventListener( "pointermove", onPointerHover );
 		scope.domElement.ownerDocument.removeEventListener( "pointermove", onPointerMove );
@@ -675,14 +675,6 @@ var TransformControls = function ( camera, domElement ) {
 
 	}
 
-	function onTouchStart( event ) {
-
-		if ( scope.enabled === false ) return;
-
-		event.preventDefault(); // prevent scrolling
-
-	}
-
 	// TODO: deprecate
 
 	this.getMode = function () {