Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fog Broken in Ocean Demo #10582

Closed
4 of 12 tasks
titansoftime opened this issue Jan 15, 2017 · 2 comments
Closed
4 of 12 tasks

Fog Broken in Ocean Demo #10582

titansoftime opened this issue Jan 15, 2017 · 2 comments
Labels
Bug

Comments

@titansoftime
Copy link
Contributor

Description of the problem

Fog support for the Ocean example (created by JBouny) has been broken since r76.

Example of it working: http://www.titansoftime.com/ocean-master/demo/
I tried to get this in a fiddle but after messing with cross origin issues and http/https mismatch errors I just hosted it on my server. This is the source files from JBouny's github which the ocean example is based on.

Current Version (fog not working anymore):
http://jsfiddle.net/titansoftime/em6kcb7s/

Not a huge issue, but I have been struggling trying to figure out what shader modification caused this.

Three.js version
  • Dev
  • r82
  • ...
Browser
  • All of them
  • Chrome
  • Firefox
  • Internet Explorer
OS
  • All of them
  • Windows
  • Linux
  • Android
  • IOS
@devpascoe
Copy link

yes, this! 👍

@mrdoob mrdoob added the Bug label Jan 18, 2017
gelibolue pushed a commit to gelibolue/three.js that referenced this issue Jan 20, 2017
Fix for mrdoob#10582
adca80d
@gelibolue gelibolue mentioned this issue Jan 20, 2017
Merged
mrdoob added a commit that referenced this issue Jan 20, 2017
@mrdoob
Merge pull request #10614 from gelibolue/10582fix
0cccf71 
Fix for #10582
@mrdoob mrdoob closed this as completed Jan 20, 2017
@titansoftime
Copy link
Contributor Author

Awesome! Thanks guys!

@devpascoe devpascoe mentioned this issue Jan 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mrdoob @devpascoe @titansoftime