Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong Variable in FBXLoader for specular color #13630

Closed
1 task done
BasicMan01 opened this issue Mar 18, 2018 · 1 comment · Fixed by #13632
Closed
1 task done

Wrong Variable in FBXLoader for specular color #13630

BasicMan01 opened this issue Mar 18, 2018 · 1 comment · Fixed by #13632
Labels
Bug

Comments

@BasicMan01
Copy link

BasicMan01 commented Mar 18, 2018 •
edited
Loading

Description:
In the following fixed issue a wrong variable for specular color ist used.

Issue reference:
#13515

Code reference:

three.js/examples/js/loaders/FBXLoader.js

Line 461 in c321634

parameters.emissive = new THREE.Color().fromArray( properties.SpecularColor.value );

I think the correct left part must be "parameters.specular".

Three.js version

  • r91
@looeee
Copy link
Collaborator

looeee commented Mar 19, 2018

Oops! I'll fix it 😅

@looeee looeee mentioned this issue Mar 19, 2018
Merged
@mrdoob mrdoob added Bug and removed Bug (easy) labels Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

FBXLoader: alphebetized material parameters looeee/three.js
4 participants
@mrdoob @looeee @Mugen87 @BasicMan01