Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange syntax in polyfill.d.ts - leading | when defining a union type #18172

Closed
OndrejSpanel opened this issue Dec 16, 2019 · 2 comments
Closed

Strange syntax in polyfill.d.ts - leading | when defining a union type #18172

OndrejSpanel opened this issue Dec 16, 2019 · 2 comments

Comments

@OndrejSpanel
Copy link
Contributor

OndrejSpanel commented Dec 16, 2019 •
edited

I was surprised by the leading | in the

three.js/src/polyfills.d.ts

Line 8 in f6aae66

| Int8Array 

export type TypedArray =
	| Int8Array
	| Uint8Array
...

I have checked Typescript grammar and it does not seem correct to me. I guess TS parsers somehow cope with this, but perhaps it would be safer to follow the specs?
@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 16, 2019

Yeah, it's more clear to clean this up 👍 . Do you want to make a PR?

@OndrejSpanel OndrejSpanel mentioned this issue Dec 16, 2019
Merged
@OndrejSpanel
Copy link
Contributor Author

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OndrejSpanel @Mugen87