Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs - LightProbe, LightProbeGenerator entries are missing! #18459

Closed
wolfgangvonludwigsburg opened this issue Jan 23, 2020 · 10 comments · Fixed by #19372
Closed

Docs - LightProbe, LightProbeGenerator entries are missing! #18459

wolfgangvonludwigsburg opened this issue Jan 23, 2020 · 10 comments · Fixed by #19372

Comments

@wolfgangvonludwigsburg
Copy link
Contributor

It seems that documentation entries for

  • THREE.LightProbe
  • THREE.LightProbeGenerator
    are missing ..
    (missing entries in <three.js>/docs/list.js)

LightProbe were integrated around r104.

What I only found is a doc entry for

  • THREE.LightProbeHelper

BTW, maybe a tiny tool would be helpful,
that could check the accordance between
the source code classes tree,
and their corresponding doc entries/file existance .. ?

Pls drop me a word, if I could contribute ..
(.. is LightProbe developer Info available ?)

@Mugen87
Copy link
Collaborator

Mugen87 commented Jan 23, 2020

Feel free to create the doc pages for LightProbe and LightProbeGenerator. You may want to start just with the technical skeleton (method names, signature etc.) and add the description with a subsequent PR. From my experience, adding the description will take noticeable more time for review.

@wolfgangvonludwigsburg
Copy link
Contributor Author

wolfgangvonludwigsburg commented Jan 23, 2020

Ok, I will try my best to do it ..
Since I am new to this, it will take a little time ..

@Mugen87
Copy link
Collaborator

Mugen87 commented Feb 22, 2020

@wolfgangvonludwigsburg Are you still planning to make this change?

@wolfgangvonludwigsburg
Copy link
Contributor Author

yes, I am on research, one more week, please ..

@DolphinIQ
Copy link
Contributor

Hey @wolfgangvonludwigsburg Any progress with the docs? 😇

@wolfgangvonludwigsburg
Copy link
Contributor Author

I'm sorry - due to Corona issues in my company I've had to shift acitivity priorities ..

  • but I'll manage it 'til end of this week.

@DolphinIQ
Copy link
Contributor

Thanks :) Would be awesome if this was included in r115

@mindinsomnia
Copy link

mindinsomnia commented May 11, 2020

Could anyone give a, for example, 2 sentence explanation of what a LightProbe in Three.js is, and how Three.js uses them? I've found almost no information after going through the docs, the source code and the examples. There's weirdly more documentation on how LightProbeHelper works than LightProbe.

Right now I'm just trying to find a basic explanation on what they even do.

I mean I'm just guessing based on experience from other engines, but would I be correct in saying you can create and place lightprobes throughout a scene and Three.js will somehow interpolate between them for indirect light? I'm guessing that's what they do but I can't find any information to confirm that or any information on how Three.js interpolates between them if that is indeed how they work, or any guides on how to use them with Three.js. Is there a limit on the number you can have in a scene?

Just a real quick summary from perhaps whoever wrote the code for LightProbes would be nice.

@Mugen87
Copy link
Collaborator

Mugen87 commented May 11, 2020

@wolfgangvonludwigsburg Any updates on this issue? If you have no time, I suggest someone else adds the documentation.

@mrdoob
Copy link
Owner

mrdoob commented May 11, 2020

@mindinsomnia

I mean I'm just guessing based on experience from other engines, but would I be correct in saying you can create and place lightprobes throughout a scene and Three.js will somehow interpolate between them for indirect light?

Not yet. That's what #18371 is trying to implement.

Currently LightProbe and PMREMGenerator kind of serves the same purpose.

However, WebXR/AR provides the light estimation from the user's camera using Spherical Harmonics which is what LightProbe uses and that'll give it more use.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants