Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve 3DMLoader conversion warnings #21638

Closed
karimi opened this issue Apr 12, 2021 · 0 comments · Fixed by #21639
Closed

Retrieve 3DMLoader conversion warnings #21638

karimi opened this issue Apr 12, 2021 · 0 comments · Fixed by #21639

Comments

@karimi
Copy link
Contributor

karimi commented Apr 12, 2021

Is your feature request related to a problem? Please describe.

3DMLoader can occasionally fail to return geometry if render meshes are missing. Right now such warnings are only posted to console. It'll be helpful if these are returned when calling .load() or .parse()

Describe the solution you'd like

A solution may be that the returned object has an array of warnings. Another solution may be that parse and load methods accept an optional onWarning callback.

Describe alternatives you've considered

The current 3DMLoader outputs such messages to console using console.warn() . I've tried a workaround to capture all console.warn messages this way but it's pretty hacky.

Additional context
Below is a screenshot of an example model that was missing render meshes. (not the default Rhino Logo model)
Screen Shot 2021-04-12 at 5 41 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants