Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new format property on the Material is not documented #22458

Closed
benpigchu opened this issue Aug 30, 2021 · 0 comments · Fixed by #22459
Closed

The new format property on the Material is not documented #22458

benpigchu opened this issue Aug 30, 2021 · 0 comments · Fixed by #22459

Comments

@benpigchu
Copy link

Is your feature request related to a problem? Please describe.

I'm trying to make a transparent version of a opaque object imported from GLTFLoader. However, the old way to do it (set transparent to true on the Material) do not works any more. After some investigation I found that #22428 changed how the renderer decides whether a Material is opaque in r132, so I changed my code to both set transparent to true and set format to RGBAFormat, and it works.

However, the format property on the Material is undocumented and it is confusing to see the code breaks in the new version.

Describe the solution you'd like

Add documentation about the format property on the Material, and also document how it affects rendering

Describe alternatives you've considered

Just revert the change, but I think it is not practice.

Additional context

Previous discussion on making a GLTF imported model transparent on the forum

@benpigchu benpigchu changed the title The new 'format' property on the Material is not documented The new format property on the Material is not documented Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants