Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTextureLoader: Properly bubble parsing errors to onError #26457

Closed
6 tasks done
gkjohnson opened this issue Jul 18, 2023 · 0 comments · Fixed by #26499
Closed
6 tasks done

DataTextureLoader: Properly bubble parsing errors to onError #26457

gkjohnson opened this issue Jul 18, 2023 · 0 comments · Fixed by #26499

Comments

@gkjohnson
Copy link
Collaborator

gkjohnson commented Jul 18, 2023

Description

The core issue is laid out in #26412 - but DataTextureLoader subclasses are not properly propagating errors in a way that can be caught or handled by applications.

Solution

Issue #26412 added a temporary fix for the issue but does not correctly address the issue. My recommendation is for the following loaders that extend DataTextureLoader should throw errors in the parse function rather than logging warnings (see here, here). It's possible other loaders have a similar issue.

Alternatives

none

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants