Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom Shaders not working in r159 anymore #27291

Closed
RemusMar opened this issue Dec 1, 2023 · 2 comments
Closed

Custom Shaders not working in r159 anymore #27291

RemusMar opened this issue Dec 1, 2023 · 2 comments

Comments

@RemusMar
Copy link
Contributor

RemusMar commented Dec 1, 2023

Description

They were working just fine until r159, now they don't.
And the worst part is that I don't get any console warning or error.

Reproduction steps

See the samples.

Code

The code is available in the samples

Live example

r158 (good) : https://necromanthus.com/Test/html5/Lara_shader.html
r159 (bad) : https://necromanthus.com/Test/html5/Lara_shader_r159.html

Screenshots

No response

Version

r159

Device

Desktop

Browser

No response

OS

Windows

@Mugen87
Copy link
Collaborator

Mugen87 commented Dec 1, 2023

That's because of #27117. The uniform boneTextureSize that you are using in your custom vertex shader code does not exist anymore. Try to update the function getBoneMatrix() like in the PR.

@RemusMar
Copy link
Contributor Author

RemusMar commented Dec 1, 2023

That's because of #27117.
The uniform boneTextureSize that you are using in your custom vertex shader code does not exist anymore.
Try to update the function getBoneMatrix() like in the PR.

Good catch!
Everything updated to r159
All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants