Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor: drop event in UIOutliner of ui.three.js not being call #28214

Closed
whyqiliao opened this issue Apr 25, 2024 · 9 comments
Closed

Editor: drop event in UIOutliner of ui.three.js not being call #28214

whyqiliao opened this issue Apr 25, 2024 · 9 comments
Labels
Milestone

Comments

@whyqiliao
Copy link

whyqiliao commented Apr 25, 2024

Description

Edge 124.0.2478.51 x64

function onDrop(event) not being call when darg and drop things in UIOutliner

Solution

add event.preventDefault(); in onDragOver()
image

Alternatives

Version
r153

Additional context

No response

@whyqiliao whyqiliao changed the title drop event in UIOutliner of ui.three.js not being call Editor: drop event in UIOutliner of ui.three.js not being call Apr 25, 2024
@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 25, 2024

function onDrop(event) not being call when darg and drop things in UIOutliner

I can't reproduce. The event listener is executed, I have verified this by setting a break point. It's also not clear to me how a call of preventDefault() in onDragOver() should fix an issue in onDrop().

Do you mind explaining what kind of user interaction is currently broken in the editor? Please share step-by-step instructions or a video so it's clear for us how to reproduce the issue.

@Mugen87 Mugen87 added the Editor label Apr 25, 2024
@whyqiliao
Copy link
Author

no problem.
First of all ,i modify the editor layout a liitle bit, but didnt change the core things.
Here is the capture video

bandicam.2024-04-25.17-19-41-065.mp4

@whyqiliao
Copy link
Author

it also occur that the browser wiredly open a new tab searching 'foo'
i found the 'foo' in Firefox needs solution in onDragStart
image

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 25, 2024

it also occur that the browser wiredly open a new tab searching 'foo'

Interesting! I've tested with Chrome, Firefox and Safari but I'm unable to reproduce the issue.

Does the tab issue only happen in Edge or it other browser as well?

@whyqiliao
Copy link
Author

I didnt try other browser, maybe it just occur in Edge?
Here is the edge info
image

@whyqiliao
Copy link
Author

It also happen in Chrome 88 x64 (i use a clean version)
image

bandicam.2024-04-25.17-46-08-362.mp4

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 25, 2024

i modify the editor layout a liitle bit,

Is it possible to reproduce the issue with the unmodified version of the editor? Meaning: https://threejs.org/editor/

@whyqiliao
Copy link
Author

the unmodified version works well, i should check my code
image

@Mugen87
Copy link
Collaborator

Mugen87 commented Apr 25, 2024

As long as the error does not occur in the official (unmodified) version of the editor, there is no need for a patch in this repository.

@Mugen87 Mugen87 added this to the r164 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants