-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ColladaLoader now loads a Scene instead of an Object3D #5754
Comments
Added to the Migration page. |
Why is |
Hmmm... It was for making it renderable... 17a4ae3 |
Sorry, I do not understand what "making it renderable" means in this case... Also, the returned scene has scale applied by the loader. Usually we do not scale a scene. And furthermore, in the loader callback, users end up adding the returned scene as a child of another scene. Unless I am missing something, the loader should return an |
It means that
Yeah, you're making me reconsider... |
I would agree with @WestLangley although you can use the collada loader for a scene it may happen quite often that you only want to load an Object3D to add anywhere, adding a scene to as scene could probably add sides effects and confusion no ? |
Yesh... I agree. I'll revert! :) |
ColladaLoader
now loads a 'Scene' instead of an 'Object3D' in the '.scene' field of the callback parameter.It's not an issue rather a fix but the info is somehow interesting.
I had a regretion due to that as I was performing a deep copy of the object in order to have instances not sharing materials indeed clone functions of Object3D and Scene are slightly different
The text was updated successfully, but these errors were encountered: