Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r72: receiveShadow some way to improve? #7319

Closed
Freeman555 opened this issue Oct 9, 2015 · 3 comments
Closed

r72: receiveShadow some way to improve? #7319

Freeman555 opened this issue Oct 9, 2015 · 3 comments

Comments

@Freeman555
Copy link

hey guys,

There is some way to improve "receiveShadow"? Self shadow has some strange disorder (looks like a black waves), pls take a look:
http://jsfiddle.net/Freeman555/xsgebh0b/1/

@MasterJames
Copy link
Contributor

I thought shadowBias or something like that would do it but maybe it's more the shadow map size after fiddling.

This is bizzare...
http://jsfiddle.net/xsgebh0b/2/
Seriously though with the Physically Based value -0.0002? aka zero

shadowBias: -0.0002,

http://jsfiddle.net/xsgebh0b/3/
Notice the difference in the shadow penumbra with the shadow map at 4k
http://jsfiddle.net/xsgebh0b/4/
http://jsfiddle.net/xsgebh0b/5/
this camera perspective reveals an obvious bug with the spectacular too right?
Was the aliasing at the edge of the shadow your issue?

#5554

@Freeman555
Copy link
Author

Yeap, it's a bug with light on shadow.

BTW Your solution fits me, thanks.

@mrdoob
Copy link
Owner

mrdoob commented Oct 9, 2015

this camera perspective reveals an obvious bug with the spectacular too right?

Not really... You can "fix" it by doing spotLight.shadowDarkness = 1. But yes, I would argue we should probably remove shadowDarkness altogether.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants