Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set mapping property of envMap at proper timing in MMDLoader #10471

Merged
merged 1 commit into from Dec 26, 2016
Merged

Set mapping property of envMap at proper timing in MMDLoader #10471

merged 1 commit into from Dec 26, 2016

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Dec 26, 2016 •
edited

This PR lets MMDLoader set mapping property of envMap at proper timing and we can remove material.needsUpdate=true which is no longer necessary.

@mrdoob mrdoob merged commit 95b2dc6 into mrdoob:dev Dec 26, 2016
@mrdoob
Copy link
Owner

mrdoob commented Dec 26, 2016

Thanks!

@takahirox takahirox deleted the FixMMDEnvMapMapping branch December 26, 2016 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takahirox @mrdoob