Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader2 Fixes - NormalsIndex & Material Mapping #10716

Merged
merged 2 commits into from Feb 3, 2017
Merged

FBXLoader2 Fixes - NormalsIndex & Material Mapping #10716

merged 2 commits into from Feb 3, 2017

Conversation

Kyle-Larson
Copy link
Contributor

Fixed more FBXLoader2 bugs

  • Fixed bug where NormalIndex was referenced as NormalsIndex.
  • Fixed bug where geometry without any assigned material had material mapping information listed as "NoMappingInformation"

- Fixed issue where `NormalIndex` node was named `NormalsIndex`
- Fixed issue where geometry with no material was given mapping type of `NoMappingInformation`
@Kyle-Larson Kyle-Larson mentioned this pull request Feb 3, 2017
11 tasks
@mrdoob mrdoob merged commit 8586ef2 into mrdoob:dev Feb 3, 2017
@mrdoob
Copy link
Owner

mrdoob commented Feb 3, 2017

Thanks!

@mrdoob
Copy link
Owner

mrdoob commented Feb 3, 2017

@Kyle-Larson Here are some more FBX that fail to load... 😇

http://files.davidoreilly.com/downloads/EXTW_UnityRigs.zip

@Kyle-Larson
Copy link
Contributor Author

@mrdoob All of these FBX files are binary exported, which we don't currently support.

@mrdoob
Copy link
Owner

mrdoob commented Feb 4, 2017

Oh, I see. Is there a way to detect that and warn the user?

Right now this is all the user gets:

screen shot 2017-02-03 at 16 12 18

@Kyle-Larson
Copy link
Contributor Author

fbx-binary-error

Perchance did I use the wrong files? I tested the files in the FBX folder. Even if there wasn't a check for binary vs. ASCII, the loader wouldn't be getting as far as to report an error like that.

@mrdoob
Copy link
Owner

mrdoob commented Feb 4, 2017

Oh... The check must be in the load()? The editor uses the parse() directly.

@Kyle-Larson
Copy link
Contributor Author

Yeah, you're right on that account. Might make more sense to put the check in parse, since that's the function that has to do the actual parsing. I'll make that quick change and make a new PR.

@Kyle-Larson Kyle-Larson deleted the feature/FBX-Normal-Index-Fix branch February 4, 2017 05:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants