Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: Simplify animation system and support unbaked animations #12758

Merged
merged 2 commits into from Nov 27, 2017

Conversation

looeee
Copy link
Collaborator

@looeee looeee commented Nov 27, 2017

The previous animation parser in the FBXLoader has a number of problems:

  • It creates a flattened array with all loaded and adding them manually to the exported Group as Group.skeleton.bones. This was then used to animate objects - so a scene with a single rotated box would have a keyframe track references .bones[ box001 ].quaternion

  • Only baked animations exported at one keyframe per frame are supported

  • Objects animated on a single axis that is not the x axis won't work - times are specified separately per axis animated axis in FBX files and the x axis times are being used to create time values for other axes

This is a simplification of the system that addresses these issues and additionally:

  • use the times directly from the FBX file instead of recalculating them frame by frame (this means that frame rate is automatic)

@mrdoob
Copy link
Owner

mrdoob commented Nov 27, 2017

Sweet!

@mrdoob mrdoob merged commit 84c0b9f into mrdoob:dev Nov 27, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 27, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants