Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Light tests failing because of assert not passed into runStdLightTests. #12779

Merged
merged 1 commit into from Nov 30, 2017
Merged

Light tests failing because of assert not passed into runStdLightTests. #12779

merged 1 commit into from Nov 30, 2017

Conversation

OndrejSpanel
Copy link
Contributor

@OndrejSpanel OndrejSpanel commented Nov 29, 2017 •
edited

Function runStdLightTests expected assert as its first parameter, but did not use it (and the tests were not giving it to it). Fixed by passing the assert around as needed.

@mrdoob mrdoob merged commit 78f9bed into mrdoob:dev Nov 30, 2017
@mrdoob
Copy link
Owner

mrdoob commented Nov 30, 2017

Thanks!

@OndrejSpanel OndrejSpanel deleted the fixLightTests branch November 30, 2017 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OndrejSpanel @mrdoob