Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable LoadingManager and GLTFLoader Method chaining #12887

Merged
merged 1 commit into from Dec 16, 2017
Merged

Enable LoadingManager and GLTFLoader Method chaining #12887

merged 1 commit into from Dec 16, 2017

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Dec 15, 2017 •
edited

This PR enables LoadingManager and GLTFLoader Method chaining by returning this from setters, like TextureLoader, FileLoader, and other loaders do.

@mrdoob mrdoob merged commit 97e7bf6 into mrdoob:dev Dec 16, 2017
@mrdoob
Copy link
Owner

mrdoob commented Dec 16, 2017

Thanks!

@takahirox takahirox deleted the MethodChaining branch December 21, 2017 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donmccurdy donmccurdy donmccurdy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takahirox @mrdoob @donmccurdy