GLTFLoader: Do not make duplicate morphTargetDictionary entries #13800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donmccurdy
reviewed
Apr 8, 2018
examples/js/loaders/GLTFLoader.js
Outdated
|
|
||
| for ( var i = 0, il = targetNames.length; i < il; i ++ ) { | ||
|
|
||
| dictionary[ targetNames[ i ] ] = i; | ||
|
|
||
| } |
There was a problem hiding this comment.
Maybe just reset mesh.morphTargetDictionary = {}? And because extras.targetNames is already an unofficial property, I think we should be very strict about what it can contain. If the length does not match, ignore the whole thing or even log an error.
if ( Object.keys( dictionary ).length === targetNames.length ) {
// ...
} else {
console.warn( 'THREE.GLTFLoader: Invalid extras.targetNames length. Ignoring names.' );
}There was a problem hiding this comment.
I like that idea because it's easier. Updated. Thanks.
donmccurdy
approved these changes
Apr 10, 2018
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to remove existing morphDictionary entries in case
targetNamesis defined, not to have duplicate dictionary entry.