TGA files support for FBXLoader #13841
Conversation
Based on @looeee mrdoob#13227 PR and discussed in mrdoob#13786 It is without DDS support that was causing problems. I know line 369 is ugly and maybe not best way to do it, could you advice me better way? `if (textureNode.FileName.slice(textureNode.FileName.lastIndexOf('.') + 1)=='tga')`
examples/js/loaders/FBXLoader.js
Outdated
|
|
||
| var texture; | ||
|
|
||
| if (textureNode.FileName.slice(textureNode.FileName.lastIndexOf('.') + 1)=='tga'){ |
There was a problem hiding this comment.
Need spaces to follow the code style. And recommended to use === instead of ==.
if ( textureNode.FileName.slice( textureNode.FileName.lastIndexOf( '.' ) + 1 ) === 'tga' ) {
There was a problem hiding this comment.
Hi @takahirox,
thanks for suggestions. I updated the PR style. Anyway I still don't know if it is the right way to check if this is TGA file. It works but maybe there is better way?
There was a problem hiding this comment.
This looks OK, but you need to account for capitalised file extensions like "TGA".
There was a problem hiding this comment.
What about if ( textureNode.FileName.slice( -3 ).toLowerCase() === 'tga' ) ?
There was a problem hiding this comment.
You're right @looeee. I updated the PR.
There was a problem hiding this comment.
IMO using .lastIndexOf( '.' ) would be more robust. For example, if ( textureNode.FileName.slice( -3 ).toLowerCase() === 'tga' ) can be match with like 'something.atga'.
I haven't looked into FBXLoader recently. Is textureNode.FileName guaranteed to be one of the known image extensions here? If so, .slice( -3 ) could be ok.
There was a problem hiding this comment.
We had an easier solution textureNode.FileName.slice( -4 ).toLowerCase() === '.tga', anyways.
updated following #takahirox suggestions
|
Thanks! |
Based on @looeee #13227 PR and discussed in #13786
It is without DDS support that was causing problems.
I know line 369 is ugly and maybe not best way to do it, could you advice me better way?
if (textureNode.FileName.slice(textureNode.FileName.lastIndexOf('.') + 1)=='tga')previous
if ( fileName.indexOf( 'image/tga' ) !== - 1 )is not working in this version...