Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FBXLoader: support morphtargets #13856

Merged
merged 12 commits into from
Apr 15, 2018
Merged

Conversation

looeee
Copy link
Collaborator

@looeee looeee commented Apr 13, 2018

Partial support for morph targets ( blend shapes ) in the FBXLoader.

Still to do:

  • only morph positions is supported for now, no morph normals
  • material.morphtargets = true needs to be set manually by the user
  • animation is not supported (the user can manually set up animation of course, but animations in the loader will be ignored)
  • remove code duplication between genGeo and genMorphGeo

fbx_morph

@looeee
Copy link
Collaborator Author

looeee commented Apr 13, 2018

Oops, I broke something when fixing conflicts. Don't merge yet!

@looeee looeee force-pushed the FBXLoader_support_morphtargets branch from 7af588d to 72afc62 Compare April 14, 2018 03:10
@looeee looeee force-pushed the FBXLoader_support_morphtargets branch from f783b7e to 71d872c Compare April 14, 2018 03:17
@looeee
Copy link
Collaborator Author

looeee commented Apr 14, 2018

OK, this should be good to go. I've split the monolithic genGeo function into genGeo, getGeoInfo, genBuffers, genFace.

Now genBuffers and genFace are reused when generating the morph target position attribute instead of duplicating the code.

@mrdoob
Copy link
Owner

mrdoob commented Apr 15, 2018

Fixed a conflict. Should be good to go now?

@looeee
Copy link
Collaborator Author

looeee commented Apr 15, 2018

Looks good!

@mrdoob mrdoob added this to the r92 milestone Apr 15, 2018
@mrdoob mrdoob merged commit bc3aa48 into mrdoob:dev Apr 15, 2018
@mrdoob
Copy link
Owner

mrdoob commented Apr 15, 2018

Thanks!

@looeee looeee deleted the FBXLoader_support_morphtargets branch January 27, 2022 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants