Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .isWebGL2() to WebGLUtils #14542

Closed
wants to merge 1 commit into from
Closed

Add .isWebGL2() to WebGLUtils #14542

wants to merge 1 commit into from

Conversation

takahirox
Copy link
Collaborator

@takahirox takahirox commented Jul 25, 2018 •
edited
Loading

This PR adds isWebGL2() to WebGLUtils and removes WebGLRenderingContext pollution. See #13717 (comment)

@WestLangley
Copy link
Collaborator

FWIW, to me, capabilities.isWebGL2 seems more natural.

@mrdoob
Copy link
Owner

mrdoob commented Jul 25, 2018

Yeah, I think I agree with @WestLangley.

@mrdoob mrdoob added this to the r95 milestone Jul 25, 2018
@takahirox takahirox mentioned this pull request Jul 25, 2018
Merged
@takahirox
Copy link
Collaborator Author

I made a new PR #14546

@takahirox takahirox closed this Jul 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r95
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@takahirox @WestLangley @mrdoob