Update Built UMD File Readability #15543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkjohnson
changed the title
donmccurdy
reviewed
Jan 8, 2019
rollup-examples.config.js
Outdated
| @@ -30,7 +44,8 @@ function createOutput( file ) { | |||
| banner: | |||
| '/**\n' + | |||
| ` * Generated from '${ path.relative( '.', inputPath.replace( /\\/, '/' ) ) }'\n` + | |||
There was a problem hiding this comment.
The regex appears to be replacing \ with /, but the output still shows \ — https://github.com/gkjohnson/three.js/blob/rollup-jsm-examples-output/examples/js/loaders/GLTFLoader.js#L2. Is this working as intended?
There was a problem hiding this comment.
Is this working as intended?
Nope! (fixed)
|
Thanks! |
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per the discussion in #15526:
Replace the
three_module_jslocal UMD variable name withTHREEto retain the source readability. Also remove the addition of the__esModulevariable onto THREE.This uses the
generateBundleRollup plugin hook to replace thethree_module_jsvariable name withTHREE. Unfortunately I didn't see a better way to control that variable name in Rollup so this is a pretty non discriminating find and replace in the file but given the code style expectations in the repo I don't think it should be a problem.You can see the new built GLTFLoader code here: https://github.com/gkjohnson/three.js/blob/rollup-jsm-examples-output/examples/js/loaders/GLTFLoader.js