OrthographicCamera: Simplify view offset calculation #18301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In scaleW / zoomW, there are (this.view.width) in the numerator and denominator
miyamonz
force-pushed
the
reduce-scale-coefficient
branch
from
99f15c5
to
5061ef6
Compare
WestLangley
changed the title
|
Thank you for your contribution! @mrdoob This is OK to merge. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is about this block. -> https://github.com/mrdoob/three.js/blob/dev/src/cameras/OrthographicCamera.js#L106-L118
Every diff to be added to left, right, top and bottom contains (scaleW / zoomW) or (scaleH / zoomH) factor, but both the scale and the zoom contains same
this.view.{width, height}term, so it can be divided.