Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MeshMatcapMaterial: Support dithering #18998

Merged
merged 1 commit into from
Mar 31, 2020
Merged

MeshMatcapMaterial: Support dithering #18998

merged 1 commit into from
Mar 31, 2020

Conversation

WestLangley
Copy link
Collaborator

MeshMatcapMaterial does not support lights, but it does support a matcap texture, and hence gradients.

Consequently this seems reasonable to me.

@WestLangley
Copy link
Collaborator Author

MeshBasicMaterial supports baked lighting. Would adding dithering support to that material also makes sense... ?

@WestLangley WestLangley added this to the r116 milestone Mar 31, 2020
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2020

MeshBasicMaterial supports baked lighting. Would adding dithering support to that material also makes sense... ?

#18997

@mrdoob mrdoob merged commit 3b81dba into mrdoob:dev Mar 31, 2020
@mrdoob
Copy link
Owner

mrdoob commented Mar 31, 2020

Thanks!

@WestLangley WestLangley deleted the dev_matcap_dither branch March 31, 2020 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@WestLangley @mrdoob