Fix TransformControl zoom for OrthographicCamera

[VJigouline]

When OrthographcCamera is used together with OrbitControls TransformControls graphical representation is not scaled correctly. This is because TransformControls was originally written for the PerspectiveCamera, where scaling is done by positioning camera further or closer to the object.
For the orthographic projection this doesn't work, because camera position is always infinitely far away from the object, so zoom factor should be used instead.
The fix contains "magical number" 1000. This was selected by experiment, but it can be changed, if there is a good reason.
Current shape of the control with control size = 1:

[mrdoob]

Can you make the code like this?

var eyeDistance;

if ( camera.isOrthographicCamera ) {

	eyeDistance = 1000 / this.camera.zoom;

} else {

	eyeDistance = this.worldPosition.distanceTo( this.cameraPosition );

}

[mrdoob]

/cc @WestLangley @arodic

[WestLangley]

This is a comment about the formatting only -- not the patch itself.

var eyeDistance = camera.isOrthographicCamera ? 1000 / this.camera.zoom : this.worldPosition.distanceTo( this.cameraPosition );

[VJigouline]

Yes. I thought about both suggested options. Which is more preferable?

[mrdoob]

Lets go with @WestLangley's.

[VJigouline]

Done and verified in my project.

[arodic]

Looks good to me

[mrdoob]

Thanks!

[WestLangley]

The fix contains "magical number" 1000. This was selected by experiment, but it can be changed, if there is a good reason.

This is a red flag that the implementation is not correct.

For example, try the fiddle in #19158 using the dev branch (not master) and an orthographic camera. It is unusable.

/ping @arodic

[arodic]

Yeah, it looks like magic number wont work. I'll fix.

Please re-open this issue.

[arodic]

Submitted a fix for this issue #19163