New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Math: if-else => switch statements #19127

Merged

mrdoob merged 1 commit into mrdoob:dev from WestLangley:dev_ifelse2switch

Apr 14, 2020

Collaborator

WestLangley commented Apr 13, 2020

Note:

We were not consistent about warning for invalid Euler.order values, so I added the warning in all three methods here.

If it is preferred that the warnings be removed, I will do so in a follow-on PR.


          if-else to switch statement

76f3c92

WestLangley added this to the r116 milestone

mrdoob merged commit 16f6994 into mrdoob:dev

Owner

mrdoob commented Apr 14, 2020

Thanks!

WestLangley deleted the dev_ifelse2switch branch

April 14, 2020 03:39

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment