Examples: Added ACESFilmicTonemappingShader #19196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for adding this 👍 Does this approximation give a better fit than the one we are already using? It will be interesting to see if the difference is at all noticeable. If it's not, then I would vote to just use the faster approximation everywhere. |
|
Thanks! |
|
how can i use test this? |
|
@looeee any idea how i can use the old ACESFilmicToneMapping shader or the new one ? |
|
@arpu best to discuss this over on the forum. |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the approximation proposed by Stephen Hill. It is used by Babylon and PlayCanvas.