Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Fixed Quaternion.lengthSq() description #19218

Merged
merged 1 commit into from
Apr 25, 2020
Merged

Docs: Fixed Quaternion.lengthSq() description #19218

merged 1 commit into from
Apr 25, 2020

Conversation

goechsler
Copy link
Contributor

8 character PR!
Am I a contributor now? ;)

Cheers!

@DefinitelyMaybe
Copy link
Contributor

tehe LGTM 👍
💭(maybe one day I'll be a contributor too)

@mrdoob mrdoob added this to the r116 milestone Apr 25, 2020
@mrdoob mrdoob merged commit f16f83d into mrdoob:dev Apr 25, 2020
@mrdoob
Copy link
Owner

mrdoob commented Apr 25, 2020

Am I a contributor now? ;)

You are! Thanks!

@mrdoob mrdoob changed the title Fix explanation of Quaternion.lengthSq() Docs: Fixed Quaternion.lengthSq() description Apr 25, 2020
@WestLangley
Copy link
Collaborator

Remember Chinese docs, too, please. :-)

@mrdoob
Copy link
Owner

mrdoob commented Apr 26, 2020

/ping @linbingquan

@linbingquan
Copy link
Contributor

linbingquan commented Apr 26, 2020 •
edited by Mugen87

related #19227

@goechsler goechsler deleted the fix-quaternion-docs branch April 28, 2020 06:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
r116
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@goechsler @DefinitelyMaybe @mrdoob @WestLangley @linbingquan