Examples: force background color on ascii example. #19352
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix a wrong behavior that happens on iOS.
If you don't set a background color, the background is assumed entirely white. Which leads to the wrong result. As followed:
The reason why this happens is a combination of iOS not handling
alpha: false
as expected and the following check insideAsciiEffect
three.js/examples/jsm/effects/AsciiEffect.js
Lines 237 to 243 in 8791f00
@zz85 I know it's been a long time since you made this, but do you recall why that check is necessary? It's not immediately obvious to me. I would think that multiplying brightness by the alpha value would be correct here.
This follows @mrdoob recommendation of just filing the minimal friction fix for this, which doesn't change
AsciiEffect
directly.